Fixed [AoD/RoF/Create] Offline voting is broken

[Notme]

Description of Bug (Include the expected results and the actual results if applicable):
It seems like servers have trouble with offline voting.
All voting information is lost, when you vote and don't login quickly - either it breaks when someone joins or when server restarts.
I should get reward on all servers depending on how many voting sites I voted (on one you need to wait 24h).

Evidence (Logs, Screenshots, etc.):
I voted yesterday and today on three sites and there was no message at all.
No idea if I got any reward.
AoD even said, that I didn't vote on it at all.

ComputerGuy_ SirComputer Hex you are in direct ccontrol of AoD/RoF/Create respectively.

Leaving screenshots so I can compare them tomorrow in offline voting test.

Spoiler

-------------------------------------------------------
Looks like this time I got reward for offline voting, but it seems like it didn't notice I voted on two servers (on third one you need to wait 24h which is dumb).
Ether it breaks when in meantime someone logs in server, of when they restart.

Spoiler

Yesterday I had 1203 cookies, 1620 tokens and 2200 topians.
Now I have 1233 cookies, 1640 tokens and 2300 topians.

It seems like you can get 15 cookies, 10 tokens and 50 topians for each voting.
If servers properly noticed, that I voted on two websites.
Your reward is triple if you vote on 3 websites in one day
One of websites requires to wait 24 hours instead of letting you vote again in midnight.
If you vote on three websites, then you get 45 cookies, 30 tokens and 150 topians it seems.

Steps to Reproduce:
1. See how many cookies/tokens/topians you have.
2. Vote on each site.
3. Restart servers.
4. Log in on them.
5. Check if you got any reward.

 

[Notme]

Voted today on three MC voting sites, then quickly hopped on servers.
It seems like servers didn't count vote from one site.
At least it didn't display message, that I voted on three different servers.

Spoiler

On RoF I got 30 cookies (10 cookies per vote, compare with screenshots in second spoiler) - since message says 10 cookies per vote it seems, that internally calculated it correctly, but failed to display three messages from three different voting sites.
On Create I got 200 Topians - looks like it failed to count vote from MinecraftServers voting site - I should get 300 Topians (100 Topians per vote).
On AoD I got 40 Tokens (20 Tokens per vote) - looks like it failed to count one vote. Also vote counter here is broken.

 

[Notme]

I voted on two servers - dumb minecraftforums requires to remember, when you voted last time yesterday >.>
Can you restart lobby Danni122112 and test if my two votes will count this time?

Edit: Can our devs make voting plugin, that would actually count votes properly even after servers restart/crash?

 

[SirComputer]

either it breaks when someone joins

When someone joins or is already online, it will show all the voting messages to them.

when server restarts

Things are getting dodgyyyyy
Any global issues I'd slap Tnm on, but these seem to be localised to specific servers.

---

For RoF at least, I'll try updating I have updated VotingPlugin. We'll see where that takes us.

 

[Notme]

When someone joins or is already online, it will show all the voting messages to them.


Things are getting dodgyyyyy
Any global issues I'd slap Tnm on, but these seem to be localised to specific servers.

---

For RoF at least, I'll try updating I have updated VotingPlugin. We'll see where that takes us.

Lets see if that worked - I voted earlier on two sites in morning.

Spoiler

Create didn't show messages, that I voted on two sites, and failed to count one site - got 100 topians.
Didn't got any reward on RoF.
Got 40 tokens as should be on AoD.

Probably I can vote on Minecraftforums now.
Edit:
RoF failed to add voting reward.
Got 20 tokens on AoD.
Create didn't show message, that I voted on it, but vote was counted.

Spoiler

 

[SirComputer]

Lets see if that worked - I voted earlier on two sites in morning.
I got reward only on Create this time.

Ah, looks like I need to do a bit of reconfiguring for our plugin. It seems like the config location has moved, so everything "reset". I'll get that worked on later.

 

[Notme]

Generally it seems like servers aren't consistent with counting votes, giving rewards and messaging.
Probably this is one of causes of why people stopped voting.

 

[Danni122112]

Ye, this needs a fix, thanks a lot raxo for helping ouT here!

 

[Notme]

I voted on two sites.

Spoiler

No reward on RoF.
40 tokens on AoD but vote counter was increased only by 1
Only 100 topians on Create - it didn't count one vote.

 

[SirComputer]

RoF rewards should be fixed (at least from my testing). I really do not want to ever have to do that again.

 

[Notme]

RoF rewards should be fixed (at least from my testing). I really do not want to ever have to do that again.

I'll vote on Minecraftforums (needs 24 hours to pass to be able to vote again) and test it.

Spoiler

Got 100 topians on Create
20 tokens on AoD
10 cookies on RoF.
I guess it worked.

 

[Notme]

I voted on servers (three sites, one dite later in day) yesterday.
Joined on servers today to see if I got reward.
Most likely they all restarted by now.

Spoiler

Got only 100 topians and no message on Create (should get 300).
Got only 10 cookies and no message on RoF (should get 30).
Got 60 tokens on AoD and no message (all 3 voting sites counted here).

---
Voted now on two sites.

Spoiler

Got only 100 topians on Create, 10 cookies on RoF, and 10 tokens on AoD. Should get 2x more.

 

[SirComputer]

Got only 100 topians on Create, 10 cookies on RoF, and 10 tokens on AoD. Should get 2x more.

Things that happen the same on every server suggests a global issue, so I’ve asked for an update to our vote distributor to see if that will help.

 

[Notme]

I voted yesterday on three websites and today too.
Should get 6xbase reward on each server.

Spoiler

Got only 10 cookies, should get 60, no voting messages here on ROF.
Got only 200 topians, should get 600 topians on Create, no voting messages.
Got 120 tokens, looks like only AoD remember votes trough restarts, only 3 voting messages though.

 

[Comp]

I've updated both the voting plugins on AoD. If it was a bug with either of these, then that should fix it. Otherwise, it'll be something wrong with something else which a CA will have to look at

 

[Notme]

I voted today on 3 voting sites and didn't got any messages.

Spoiler

 

[Notme]

Voted on 3 voting sites.

Spoiler

Got only 200 topians - Create failed to count one site (MinecraftForums most likely).
Got only 40 tokens - AoD failed to count one site (MinecraftForums is suspicious).
Got only 20 cookies - RoF failed to count one site (MinecraftForums most likely).

 

[SirComputer]

I've went and updated that global vote distributor myself. Seeing as servers have the same issues at a time, I'm hoping this will be the issue and can be fixed. This should activate when Bungee restarts.

 

[Notme]

Voted on three voting sites - few hours later on MinecraftForums, as on it exactly 24 hours must pass since last vote.
Didn't got any messages.

Spoiler

Also I didn't got any rewards.

 

[Comp]

We are looking into this, after updating the plugins I noticed there's a bunch of efforts in console with voting. I'll have a look more into this when I get time

 

[SirComputer]

I had a look - that version seemed to receive votes fine, but telling servers about them just didn't work. I'm reverting to the previous version, because I've got no idea what's happening with it, it isn't mine to play about with and I don't have the time right now. Perhaps we might just have to try and completely redo our voting system or something.

 

[Notme]

I voted on two sites offline and on minecraftforums while on servers lobby.

Spoiler

Got reward from Create, RoF and AoD only for voting on MinecraftForums, when I was in lobby.
Two other voting sites were ignored.

 

[Notme]

Spoiler

Voted on two sites yesterday and three today.
I should get 5 rewards and messages.
Got 400 Topians on Create - one vote got lost.
Got 40 Cookies - one vote got lost.
Got 100 Tokens - all 5 sites counted.

 

[Notme]

It appears this bug is back.
I vote on servers everyday.
Got no reward on AoD and Create (RoF was offline).

 

[Notme]

I didn't get any reward or at least any message of getting reward - I guess voting plugin is broken beyond repair again.